amd/orcaslicer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix for #7301 - Endless loop telling me 'Supports work better if the following feature is enabled: bridging perimeters' when setting 'generate support material' on a single object

Browse source 
This bug was from 0c29eb9943
This commit is contained in:
YuSanka 2021-11-15 10:47:35 +01:00
parent 5dfba04e02
commit 871311c95c
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/slic3r/GUI/ConfigManipulation.cpp
View file

@ -162,8 +162,8 @@ void ConfigManipulation::update_print_fff_config(DynamicPrintConfig* config, con
if (config->opt_bool("support_material")) { if (config->opt_bool("support_material")) {
// Ask only once. // Ask only once.
if (!m_support_material_overhangs_queried) { if (!support_material_overhangs_queried) {
m_support_material_overhangs_queried = true; support_material_overhangs_queried = true;
if (!config->opt_bool("overhangs")/* != 1*/) { if (!config->opt_bool("overhangs")/* != 1*/) {
wxString msg_text = _(L("Supports work better, if the following feature is enabled:\n" wxString msg_text = _(L("Supports work better, if the following feature is enabled:\n"
"- Detect bridging perimeters")); "- Detect bridging perimeters"));
@ -182,7 +182,7 @@ void ConfigManipulation::update_print_fff_config(DynamicPrintConfig* config, con
} }
} }
else { else {
m_support_material_overhangs_queried = false; support_material_overhangs_queried = false;
} }
if (config->option<ConfigOptionPercent>("fill_density")->value == 100) { if (config->option<ConfigOptionPercent>("fill_density")->value == 100) {

7
src/slic3r/GUI/ConfigManipulation.hpp
View file

@ -17,11 +17,14 @@ class ModelConfig;
namespace GUI { namespace GUI {
// This variable have to be static because of use its value from Preset configuration
// and from object/parts configuration from the Settings in sidebar
static bool support_material_overhangs_queried {false};
class ConfigManipulation class ConfigManipulation
{ {
bool is_msg_dlg_already_exist{ false }; bool is_msg_dlg_already_exist{ false };
bool m_support_material_overhangs_queried{false};
bool m_is_initialized_support_material_overhangs_queried{ false }; bool m_is_initialized_support_material_overhangs_queried{ false };
// function to loading of changed configuration // function to loading of changed configuration
@ -63,7 +66,7 @@ public:
void initialize_support_material_overhangs_queried(bool queried) void initialize_support_material_overhangs_queried(bool queried)
{ {
m_is_initialized_support_material_overhangs_queried = true; m_is_initialized_support_material_overhangs_queried = true;
m_support_material_overhangs_queried = queried; support_material_overhangs_queried = queried;
} }
}; };