amd/orcaslicer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

ENH: popup different warning message for unsupported sharp tails

Browse source 
1. unsupported sharp tails and large overhang have different messages
2. do not popup warning for total area (only warning for one single
   large overhang)

Change-Id: I153e559915a92c6676468539cf619dafe915f997
(cherry picked from commit 67b593150f8de847d9b1999bf0d7a549eb1ef154)
This commit is contained in:
Arthur 2022-08-15 17:44:49 +08:00 committed by Lane.Wei
parent 54012ba11b
commit 4ef43af2dd
2 changed files with 28 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/libslic3r/Print.hpp
View file

@ -49,6 +49,12 @@ struct groupedVolumeSlices
ExPolygons slices; ExPolygons slices;
}; };
enum SupportNecessaryType {
NoNeedSupp=0,
SharpTail,
LargeOverhang,
};
namespace FillAdaptive { namespace FillAdaptive {
struct Octree; struct Octree;
struct OctreeDeleter; struct OctreeDeleter;
@ -457,7 +463,7 @@ private:
std::pair<FillAdaptive::OctreePtr, FillAdaptive::OctreePtr> prepare_adaptive_infill_data(); std::pair<FillAdaptive::OctreePtr, FillAdaptive::OctreePtr> prepare_adaptive_infill_data();
// BBS // BBS
bool is_support_necessary(); SupportNecessaryType is_support_necessary();
// XYZ in scaled coordinates // XYZ in scaled coordinates
Vec3crd m_size; Vec3crd m_size;

35
src/libslic3r/PrintObject.cpp
View file

@ -419,11 +419,17 @@ void PrintObject::generate_support_material()
m_print->throw_if_canceled(); m_print->throw_if_canceled();
} else { } else {
// BBS: pop a warning if objects have significant amount of overhangs but support material is not enabled // BBS: pop a warning if objects have significant amount of overhangs but support material is not enabled
if (this->is_support_necessary()) { SupportNecessaryType sntype = this->is_support_necessary();
if (sntype != NoNeedSupp) {
m_print->set_status(50, L("Checking support necessity")); m_print->set_status(50, L("Checking support necessity"));
if (sntype == SharpTail) {
std::string warning_message = format(L("It seems object %s needs support to print. Please enable support generation."), this->model_object()->name); std::string warning_message = format(L("It seems object %s has completely floating regions. Please re-orient the object or enable support generation."),
this->active_step_add_warning(PrintStateBase::WarningLevel::CRITICAL, warning_message, PrintStateBase::SlicingNeedSupportOn); this->model_object()->name);
this->active_step_add_warning(PrintStateBase::WarningLevel::CRITICAL, warning_message, PrintStateBase::SlicingNeedSupportOn);
} else {
std::string warning_message = format(L("It seems object %s has large overhangs. Please enable support generation."), this->model_object()->name);
this->active_step_add_warning(PrintStateBase::WarningLevel::CRITICAL, warning_message, PrintStateBase::SlicingNeedSupportOn);
}
} }
#if 0 #if 0
@ -2447,7 +2453,7 @@ template void PrintObject::remove_bridges_from_contacts<Polygons>(
float max_bridge_length, bool break_bridge); float max_bridge_length, bool break_bridge);
bool PrintObject::is_support_necessary() SupportNecessaryType PrintObject::is_support_necessary()
{ {
static const double super_overhang_area_threshold = SQ(scale_(5.0)); static const double super_overhang_area_threshold = SQ(scale_(5.0));
@ -2470,7 +2476,7 @@ bool PrintObject::is_support_necessary()
for (const ExPolygon& expoly : layerm->raw_slices) { for (const ExPolygon& expoly : layerm->raw_slices) {
// detect sharp tail // detect sharp tail
if (intersection_ex({ expoly }, lower_layer_offseted).empty()) if (intersection_ex({ expoly }, lower_layer_offseted).empty())
return true; return SharpTail;
} }
} }
@ -2502,18 +2508,19 @@ bool PrintObject::is_support_necessary()
double super_overhang_area = 0.0; double super_overhang_area = 0.0;
for (Polygon& poly : super_overhang_polys) { for (Polygon& poly : super_overhang_polys) {
bool is_ccw = poly.is_counter_clockwise(); bool is_ccw = poly.is_counter_clockwise();
double area_ = poly.area();
if (is_ccw) { if (is_ccw) {
if (super_overhang_area > super_overhang_area_threshold) if (area_ > super_overhang_area_threshold)
return true; return LargeOverhang;
super_overhang_area = poly.area(); super_overhang_area += area_;
} }
else { else {
super_overhang_area -= poly.area(); super_overhang_area -= area_;
} }
} }
if (super_overhang_area > super_overhang_area_threshold) //if (super_overhang_area > super_overhang_area_threshold)
return true; // return LargeOverhang;
// 3. check overhang distance // 3. check overhang distance
const double distance_threshold_scaled = extrusion_width_scaled * 2; const double distance_threshold_scaled = extrusion_width_scaled * 2;
@ -2528,10 +2535,10 @@ bool PrintObject::is_support_necessary()
}), }),
exceed_overhang.end()); exceed_overhang.end());
if (!exceed_overhang.empty()) if (!exceed_overhang.empty())
return true; return LargeOverhang;
} }
return false; return NoNeedSupp;
} }
static void project_triangles_to_slabs(ConstLayerPtrsAdaptor layers, const indexed_triangle_set &custom_facets, const Transform3f &tr, bool seam, std::vector<Polygons> &out) static void project_triangles_to_slabs(ConstLayerPtrsAdaptor layers, const indexed_triangle_set &custom_facets, const Transform3f &tr, bool seam, std::vector<Polygons> &out)