amd/orcaslicer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Use binary search for get_layer_range.

Browse source 
Gives a 13% speed up on Teethy_Tiki.stl (thing:49334) with default settings
on my laptop.
When $self->layers->[0]->slice_z == $min_z the returned $min_layer value is
0 rather than the (incorrect?) -1 returned by the old code.
This commit is contained in:
Mark Hindess 2013-04-18 19:29:05 +01:00
parent 51d140d7d7
commit 407de02fe4
1 changed files with 25 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
lib/Slic3r/Print/Object.pm
View file

@ -95,18 +95,33 @@ sub get_layer_range {
# $min_layer is the uppermost layer having slice_z <= $min_z # $min_layer is the uppermost layer having slice_z <= $min_z
# $max_layer is the lowermost layer having slice_z >= $max_z # $max_layer is the lowermost layer having slice_z >= $max_z
my ($min_layer, $max_layer) = (0, undef); my ($min_layer, $max_layer);
for my $i (0 .. $#{$self->layers}) {
if ($self->layers->[$i]->slice_z >= $min_z) { my ($bottom, $top) = (0, $#{$self->layers});
$min_layer = $i - 1; while (1) {
for my $k ($i .. $#{$self->layers}) { my $mid = $bottom+int(($top - $bottom)/2);
if ($self->layers->[$k]->slice_z >= $max_z) { if ($mid == $top || $mid == $bottom) {
$max_layer = $k - 1; $min_layer = $mid;
last;
}
}
last; last;
} }
if ($self->layers->[$mid]->slice_z >= $min_z) {
$top = $mid;
} else {
$bottom = $mid;
}
}
$top = $#{$self->layers};
while (1) {
my $mid = $bottom+int(($top - $bottom)/2);
if ($mid == $top || $mid == $bottom) {
$max_layer = $mid;
last;
}
if ($self->layers->[$mid]->slice_z < $max_z) {
$bottom = $mid;
} else {
$top = $mid;
}
} }
return ($min_layer, $max_layer); return ($min_layer, $max_layer);
} }